Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap text inscriptions #1056

Closed
wants to merge 5 commits into from
Closed

Wrap text inscriptions #1056

wants to merge 5 commits into from

Conversation

casey
Copy link
Collaborator

@casey casey commented Dec 22, 2022

Depends on #1054.

Before

Screen Shot 2022-12-22 at 2 50 21 PM

After

Screen Shot 2022-12-22 at 2 49 11 PM

@casey casey requested a review from raphjaph December 23, 2022 09:49
raphjaph
raphjaph approved these changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests don't pass but seems like you're just missing the class=inscription some places. Other than that looks good.

Didn't understand some of the CSS properties but googled them.

@raphjaph raphjaph self-requested a review December 23, 2022 11:11
@casey
Copy link
Collaborator Author

casey commented Dec 23, 2022

Closing, I think I accidentally included these changes in another PR.

@casey casey closed this Dec 23, 2022
@casey casey deleted the wrap-pre branch December 23, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph Awaiting requested review from raphjaph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph